Quellcode durchsuchen

fix: bug #324

* fix: bug #324

Fail to cancel delay job instance by id via API

* style: correct log

* style: update log

Co-authored-by: Echo009 <ech0.extreme@foxmail.com>
Justin Zhang vor 2 Jahren
Ursprung
Commit
75c88c32ed

+ 2 - 2
powerjob-server/powerjob-server-core/src/main/java/tech/powerjob/server/core/instance/InstanceService.java

@@ -191,8 +191,8 @@ public class InstanceService {
      * @param instanceId 任务实例
      */
     @DesignateServer
-    public void cancelInstance(Long instanceId) {
-        log.info("[Instance-{}] try to cancel the instance.", instanceId);
+    public void cancelInstance(Long appId, Long instanceId) {
+        log.info("[Instance-{}] try to cancel the instance with appId {}.", instanceId, appId);
 
         try {
             InstanceInfoDO instanceInfo = fetchInstanceInfo(instanceId);

+ 1 - 1
powerjob-server/powerjob-server-starter/src/main/java/tech/powerjob/server/web/controller/OpenAPIController.java

@@ -126,7 +126,7 @@ public class OpenAPIController {
     @PostMapping(OpenAPIConstant.CANCEL_INSTANCE)
     public ResultDTO<Void> cancelInstance(Long instanceId, Long appId) {
         checkInstanceIdValid(instanceId, appId);
-        instanceService.cancelInstance(instanceId);
+        instanceService.cancelInstance(appId, instanceId);
         return ResultDTO.success(null);
     }