瀏覽代碼

Add Status and ExecuteType class unit tests #1465 (#1536)

* Add Status and ExecuteType class unit tests #1465

* formated function name
elonlo 5 年之前
父節點
當前提交
6738cefa2e

+ 2 - 10
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java

@@ -248,8 +248,8 @@ public enum Status {
     KERBEROS_STARTUP_STATE(100001,"get kerberos startup state error"),
     ;
 
-    private int code;
-    private String msg;
+    private final int code;
+    private final String msg;
 
     private Status(int code, String msg) {
         this.code = code;
@@ -260,15 +260,7 @@ public enum Status {
         return this.code;
     }
 
-    public void setCode(int code) {
-        this.code = code;
-    }
-
     public String getMsg() {
         return this.msg;
     }
-
-    public void setMsg(String msg) {
-        this.msg = msg;
-    }
 }

+ 32 - 0
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/enums/ExecuteTypeTest.java

@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.api.enums;
+
+import org.junit.Test;
+import static org.junit.Assert.*;
+
+public class ExecuteTypeTest {
+
+    @Test
+    public void testGetEnum() {
+        assertEquals(ExecuteType.REPEAT_RUNNING, ExecuteType.getEnum(1));
+        assertEquals(ExecuteType.RECOVER_SUSPENDED_PROCESS, ExecuteType.getEnum(2));
+        assertEquals(ExecuteType.START_FAILURE_TASK_PROCESS, ExecuteType.getEnum(3));
+        assertEquals(ExecuteType.STOP, ExecuteType.getEnum(4));
+        assertEquals(ExecuteType.PAUSE, ExecuteType.getEnum(5));
+    }
+}

+ 34 - 0
dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/enums/StatusTest.java

@@ -0,0 +1,34 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.dolphinscheduler.api.enums;
+
+import org.junit.Test;
+import static org.junit.Assert.*;
+
+public class StatusTest {
+
+    @Test
+    public void testGetCode() {
+        assertEquals(Status.SUCCESS.getCode(), 0);
+        assertNotEquals(Status.REQUEST_PARAMS_NOT_VALID_ERROR.getCode(), 0);
+    }
+
+    @Test
+    public void testGetMsg() {
+        assertEquals("success", Status.SUCCESS.getMsg());
+    }
+}

+ 1 - 0
pom.xml

@@ -649,6 +649,7 @@
 						<include>**/common/queue/*.java</include>
 						<include>**/api/utils/CheckUtilsTest.java</include>
 						<include>**/api/utils/FileUtilsTest.java</include>
+						<include>**/api/enums/*.java</include>
 						<include>**/alert/utils/ExcelUtilsTest.java</include>
 						<include>**/alert/utils/FuncUtilsTest.java</include>
 						<include>**/alert/utils/JSONUtilsTest.java</include>