Selaa lähdekoodia

[Imporvement #5725][CheckStyle] upgrade checkstyle file (#5789)

* [Imporvement #5725][CheckStyle] upgrade checkstyle file
  Upgrade checkstyle.xml to support checkstyle version 8.24+

* change ci checkstyle version
Wenjun Ruan 3 vuotta sitten
vanhempi
commit
16986c3c65
2 muutettua tiedostoa jossa 6 lisäystä ja 6 poistoa
  1. 1 1
      .github/workflows/ci_ut.yml
  2. 5 5
      style/checkstyle.xml

+ 1 - 1
.github/workflows/ci_ut.yml

@@ -108,7 +108,7 @@ jobs:
           CHECKSTYLE_CONFIG: style/checkstyle.xml
           REVIEWDOG_VERSION: v0.10.2
         run: |
-          wget -O - -q https://github.com/checkstyle/checkstyle/releases/download/checkstyle-8.22/checkstyle-8.22-all.jar > /opt/checkstyle.jar
+          wget -O - -q https://github.com/checkstyle/checkstyle/releases/download/checkstyle-8.43/checkstyle-8.43-all.jar > /opt/checkstyle.jar
           wget -O - -q https://raw.githubusercontent.com/reviewdog/reviewdog/master/install.sh | sh -s -- -b /opt ${REVIEWDOG_VERSION}
           java -jar /opt/checkstyle.jar "${WORKDIR}" -c "${CHECKSTYLE_CONFIG}"  -f xml \
                | /opt/reviewdog -f=checkstyle \

+ 5 - 5
style/checkstyle.xml

@@ -34,6 +34,11 @@
         <property name="optional" value="true"/>
     </module>
 
+    <module name="LineLength">
+        <property name="max" value="200"/>
+        <property name="ignorePattern" value="^ *\* *[^ ]+$"/>
+    </module>
+
     <module name="TreeWalker">
         <module name="OuterTypeFilename">
             <property name="severity" value="error"/>
@@ -73,11 +78,6 @@
             <property name="allowNonPrintableEscapes" value="true"/>
         </module>
 
-        <module name="LineLength">
-            <property name="max" value="200"/>
-            <property name="ignorePattern" value="^ *\* *[^ ]+$"/>
-        </module>
-
         <module name="EmptyBlock">
             <property name="option" value="TEXT"/>
             <property name="tokens" value="LITERAL_TRY, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"/>